[Lldb-commits] [PATCH] D109004: [lldb] Catch all exceptions when checking if simulator exists

[Augusto Noronha via Phabricator via lldb-commits]

augusto2112 added a comment.

My initial thought was that xcodebuild is throwing some other error (maybe, for some reason, it times out, which is a `subprocess.TimeoutExpired` exception), which is why my solution was to catch //any// exception thrown by `subprocess.check_output`.

Many the security agent is the one outputting the error, and xcodebuild just returns as if everything is fine? I could change the affected test and add a try/catch around the json parsing, and abort the test if that fails.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109004/new/

https://reviews.llvm.org/D109004