[Lldb-commits] [PATCH] D108889: Use dSYM SymbolFile Sections file addr instead of ObjectFile Section file addr when they differ in ObjectFileMachO

[Greg Clayton via Phabricator via lldb-commits]

clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.

So do the shared library files on disk that are exploded from a shared cache of an iOS device have the file addresses set to where they are in the shared cache? I am guessing this must the issue that you were running into where the module was not in memory by still it needed to have its file addresses adjusted.

Besides some indentation, and possibly logging when we modify the file address, this LGTM.



================
Comment at: lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp:1692-1705
         // Make sure we've parsed the symbol table from the ObjectFile before
         // we go around changing its Sections.
         module_sp->GetObjectFile()->GetSymtab();
         // eh_frame would present the same problems but we parse that on a per-
         // function basis as-needed so it's more difficult to remove its use of
         // the Sections.  Realistically, the environments where this code path
         // will be taken will not have eh_frame sections.
----------------
unindent this code? Or is phabricator just not showing that this was unindented?


================
Comment at: lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp:1700
 
         unified_section_sp->SetFileAddress(load_cmd.vmaddr);
 
----------------
This seems like a good thing to log to a log channel maybe?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108889/new/

https://reviews.llvm.org/D108889