[Lldb-commits] [PATCH] D108817: [LLDB] Fix 'std::out_of_range' crashing bug when file name completion using file path.

Raphael Isemann via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Aug 30 05:14:39 PDT 2021

teemperor accepted this revision.
teemperor added a comment.
This revision is now accepted and ready to land.

In D108817#2972047 <https://reviews.llvm.org/D108817#2972047>, @HirokiImai wrote:

> Thanks for the review!
> I didn't know how to write tests very well, so the review was very helpful for me.
> I found the LLVM project to be beautiful in its componentization. I'll learn more about it.

You're welcome and thanks for the patch! I'll merge this for you.

Small note: The test here is not how tests are usually written. The test here has to spawn a virtual terminal to test the command line interface (editline) code, so that's why it uses the special `PExpectTest` test class. You might want to check out tests that were recently added to the `lldb/test/API` folder to see how LLDB tests usually look like.

  rG LLVM Github Monorepo



More information about the lldb-commits mailing list