[Lldb-commits] [PATCH] D107767: Fix break introduced in 14735ca

Robin Giese via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Aug 9 07:53:04 PDT 2021


rgiese created this revision.
rgiese requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.

The `File::OpenOptions` were renamed; this fixes up a callsite that breaks for macOS builds.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D107767

Files:
  lldb/source/Plugins/Platform/MacOSX/objcxx/PlatformiOSSimulatorCoreSimulatorSupport.mm


Index: lldb/source/Plugins/Platform/MacOSX/objcxx/PlatformiOSSimulatorCoreSimulatorSupport.mm
===================================================================
--- lldb/source/Plugins/Platform/MacOSX/objcxx/PlatformiOSSimulatorCoreSimulatorSupport.mm
+++ lldb/source/Plugins/Platform/MacOSX/objcxx/PlatformiOSSimulatorCoreSimulatorSupport.mm
@@ -426,9 +426,9 @@
         if (created_fd >= 0) {
           auto file_options = File::OpenOptions(0);
           if ((oflag & O_RDWR) || (oflag & O_RDONLY))
-            file_options |= File::eOpenOptionRead;
+            file_options |= File::eOpenOptionReadOnly;
           if ((oflag & O_RDWR) || (oflag & O_RDONLY))
-            file_options |= File::eOpenOptionWrite;
+            file_options |= File::eOpenOptionWriteOnly;
           file = std::make_shared<NativeFile>(created_fd, file_options, true);
           [options setValue:[NSNumber numberWithInteger:created_fd] forKey:key];
           return error; // Success


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D107767.365183.patch
Type: text/x-patch
Size: 975 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20210809/920f5e08/attachment.bin>


More information about the lldb-commits mailing list