[Lldb-commits] [lldb] 116b112 - [lldb] [test] Use Windows-friendly modes in vFile O_CREAT tests

[Michał Górny via lldb-commits]

Author: Michał Górny
Date: 2021-08-09T15:43:08+02:00
New Revision: 116b112bbfe043aba16d732c2eec783f0b817bb4

URL: https://github.com/llvm/llvm-project/commit/116b112bbfe043aba16d732c2eec783f0b817bb4
DIFF: https://github.com/llvm/llvm-project/commit/116b112bbfe043aba16d732c2eec783f0b817bb4.diff

LOG: [lldb] [test] Use Windows-friendly modes in vFile O_CREAT tests

Added: 
    

Modified: 
    lldb/test/API/tools/lldb-server/TestGdbRemotePlatformFile.py

Removed: 
    


################################################################################
diff  --git a/lldb/test/API/tools/lldb-server/TestGdbRemotePlatformFile.py b/lldb/test/API/tools/lldb-server/TestGdbRemotePlatformFile.py
index 8b58ef4c18e4..54129f9420a0 100644
--- a/lldb/test/API/tools/lldb-server/TestGdbRemotePlatformFile.py
+++ b/lldb/test/API/tools/lldb-server/TestGdbRemotePlatformFile.py
@@ -45,11 +45,9 @@ def test_platform_file_wronly_trunc(self):
     def test_platform_file_rdwr_trunc(self):
         self.vFile_test(read=True, write=True, trunc=True)
 
-    @expectedFailureAll(oslist=["windows"])
     def test_platform_file_wronly_creat(self):
         self.vFile_test(write=True, creat=True)
 
-    @expectedFailureAll(oslist=["windows"])
     def test_platform_file_wronly_creat_excl(self):
         self.vFile_test(write=True, creat=True, excl=True)
 
@@ -111,7 +109,7 @@ def vFile_test(self, read=False, write=False, append=False, trunc=False,
         if excl:
             mode |= 0x800
 
-        old_umask = os.umask(0o22)
+        old_umask = os.umask(0)
         try:
             server = self.connect_to_debug_monitor()
         finally:
@@ -137,7 +135,7 @@ def vFile_test(self, read=False, write=False, append=False, trunc=False,
             # open the file for reading
             self.do_handshake()
             self.test_sequence.add_log_lines(
-                ["read packet: $vFile:open:%s,%x,1a0#00" % (
+                ["read packet: $vFile:open:%s,%x,1b6#00" % (
                     binascii.b2a_hex(temp_path.encode()).decode(),
                     mode),
                  {"direction": "send",
@@ -211,7 +209,7 @@ def vFile_test(self, read=False, write=False, append=False, trunc=False,
                 if creat:
                     temp_file = open(temp_path, "rb")
                     self.assertEqual(os.fstat(temp_file.fileno()).st_mode & 0o7777,
-                                     0o640)
+                                     0o666)
                 temp_file.seek(0)
                 data = test_data.encode()
                 if trunc or creat: