[Lldb-commits] [PATCH] D107528: [llvm][clang][NFC] updates inline licence info

Aaron Ballman via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Aug 5 05:13:39 PDT 2021


aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

There are some spurious whitespace changes that should be dropped, but otherwise, this LGTM. Thank you for the cleanup!



================
Comment at: clang/lib/Tooling/DependencyScanning/ModuleDepCollector.cpp:115
     return;
-  
   // This has to be delayed as the context hash can change at the start of
----------------
Spurious whitespace change.


================
Comment at: llvm/lib/Analysis/DevelopmentModeInlineAdvisor.cpp:35
     cl::desc(R"(Path to SavedModel from the previous training iteration.
-The directory is also expected to contain a JSON specification of the 
-outputs expected to be logged, where the first entry must be the 
-inlining decision. The file containing the specification should be 
-called output_spec.json. The expected JSON value is an array of 
-dictionaries. Each dictionary should have 2 keys: 
+The directory is also expected to contain a JSON specification of the
+outputs expected to be logged, where the first entry must be the
----------------
Unrelated whitespace changes.


================
Comment at: llvm/lib/BinaryFormat/MsgPackDocumentYAML.cpp:249
 }
-
----------------
Unrelated whitespace change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107528/new/

https://reviews.llvm.org/D107528



More information about the lldb-commits mailing list