[Lldb-commits] [PATCH] D107386: [LLDB][GUI] Add Breakpoints window

Omar Emara via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Aug 6 14:05:29 PDT 2021

OmarEmaraDev added a comment.

@clayborg With you suggestions it currently looks like this. The concern I have is that lines are now 36 characters longer, and some important information are now truncated. The breakpoint and breakpoint locations IDs seems to be just the index of the objects in the tree, are they not? In this case, they seem redundant to me. Similarly, the address takes a lot of space and is included in the next level of details, so it might not be as important to include in this level either.

F18404076: 20210806-225259.png <https://reviews.llvm.org/F18404076>

I am having some difficulties adding the last level of details. My initial approach was to add and compute a StringList containing all the details to the BreakpointLocationTreeDelegate. Then I added a  StringTreeDelegate that have the string from the string list in its user data which  it then simply draws. The problem, I realized, is that the BreakpointLocationTreeDelegate is shared between all Breakpoint Location items, so the list is overwritten by different elements. What I did was instance multiple BreakpointLocationTreeDelegate for each item, but that tuned more involved that I thought, so I am not sure what the best approach would be now. What do you think?

  rG LLVM Github Monorepo



More information about the lldb-commits mailing list