[Lldb-commits] [PATCH] D107659: [nfc] [lldb] Assertions for D106270 - [DWARF5] Fix offset check when using .debug_names

[Jan Kratochvil via Phabricator via lldb-commits]

jankratochvil updated this revision to Diff 364861.
jankratochvil added a comment.

In D107659#2931836 <https://reviews.llvm.org/D107659#2931836>, @clayborg wrote:

> Can we not just grab the skeleton unit when/if needed instead of asserting in many places?

I agree it could be unified for API simplicity to be always the skeleton unit, thanks for the idea. Done in this patch. Still I believe it should be asserted as unfortunately with the current Unit types it cannot be compile-time checked.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107659/new/

https://reviews.llvm.org/D107659

Files:
  lldb/source/Plugins/SymbolFile/DWARF/AppleDWARFIndex.cpp
  lldb/source/Plugins/SymbolFile/DWARF/DWARFIndex.h
  lldb/source/Plugins/SymbolFile/DWARF/DebugNamesDWARFIndex.cpp
  lldb/source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.cpp
  lldb/source/Plugins/SymbolFile/DWARF/NameToDIE.cpp
  lldb/source/Plugins/SymbolFile/DWARF/NameToDIE.h
  lldb/test/Shell/SymbolFile/DWARF/x86/Inputs/find-variable-file-3.cpp
  lldb/test/Shell/SymbolFile/DWARF/x86/find-variable-file.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D107659.364861.patch
Type: text/x-patch
Size: 5907 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20210806/a30ed4eb/attachment.bin>