[Lldb-commits] [PATCH] D107434: fix D103172

[Greg Clayton via Phabricator via lldb-commits]

clayborg added a comment.

In D107434#2924761 <https://reviews.llvm.org/D107434#2924761>, @teemperor wrote:

> I think this part of the patch can just be reverted. Thanks for tracking this down! Reverted the respective changes in e4977f9cb58ff7820d0287ba309490af57787749 <https://reviews.llvm.org/rGe4977f9cb58ff7820d0287ba309490af57787749>
>
> Feel free to close this. I'll see that we can give this code some test coverage.

Couldn't e4977f9cb58ff7820d0287ba309490af57787749 <https://reviews.llvm.org/rGe4977f9cb58ff7820d0287ba309490af57787749>, which looks like:

  -  for (DWARFDIE src_die : src_class_die.children()) {
  +  for (src_die = src_class_die.GetFirstChild(); src_die.IsValid();
  +       src_die = src_die.GetSibling()) {

Just been:

  -  for (DWARFDIE src_die : src_class_die.children()) {
  + for (src_die : src_class_die.children()) {

?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107434/new/

https://reviews.llvm.org/D107434