[Lldb-commits] [lldb] 4367cba - [lldb] Move comment about noindex next to line it refers to

Nico Weber via lldb-commits lldb-commits at lists.llvm.org
Tue Aug 3 13:14:27 PDT 2021


Author: Nico Weber
Date: 2021-08-03T22:14:12+02:00
New Revision: 4367cbab4cf2cbf8f81a24bdcc2dc0612b932aa5

URL: https://github.com/llvm/llvm-project/commit/4367cbab4cf2cbf8f81a24bdcc2dc0612b932aa5
DIFF: https://github.com/llvm/llvm-project/commit/4367cbab4cf2cbf8f81a24bdcc2dc0612b932aa5.diff

LOG: [lldb] Move comment about noindex next to line it refers to

The comment was originally added in 34769d80d. Then D44526
removed the flag added there (but kept the comment), and then
D66966 reintroduced a .noindex dir (which D68606 and then 33fca97880
moved around a bit).

No behavior change.

Differential Revision: https://reviews.llvm.org/D107341

Added: 
    

Modified: 
    lldb/test/API/CMakeLists.txt
    lldb/test/CMakeLists.txt

Removed: 
    


################################################################################
diff  --git a/lldb/test/API/CMakeLists.txt b/lldb/test/API/CMakeLists.txt
index 7625a4e5e29c..3124ca602e8e 100644
--- a/lldb/test/API/CMakeLists.txt
+++ b/lldb/test/API/CMakeLists.txt
@@ -37,11 +37,6 @@ set(LLDB_TEST_USER_ARGS
   ""
   CACHE STRING "Specify additional arguments to pass to test runner. For example: '-C gcc -C clang -A i386 -A x86_64'")
 
-# The .noindex suffix is a marker for Spotlight to never index the
-# build directory.  LLDB queries Spotlight to locate .dSYM bundles
-# based on the UUID embedded in a binary, and because the UUID is a
-# hash of filename and .text section, there *will* be conflicts inside
-# the build directory.
 set(LLDB_TEST_COMMON_ARGS
   -u CXXFLAGS
   -u CFLAGS

diff  --git a/lldb/test/CMakeLists.txt b/lldb/test/CMakeLists.txt
index 584cacbb99c1..ca60295a0054 100644
--- a/lldb/test/CMakeLists.txt
+++ b/lldb/test/CMakeLists.txt
@@ -12,6 +12,11 @@ if(LLDB_BUILT_STANDALONE)
 endif()
 
 # Configure the build directory.
+# The .noindex suffix is a marker for Spotlight to never index the
+# build directory.  LLDB queries Spotlight to locate .dSYM bundles
+# based on the UUID embedded in a binary, and because the UUID is a
+# hash of filename and .text section, there *will* be conflicts inside
+# the build directory.
 set(LLDB_TEST_BUILD_DIRECTORY "${PROJECT_BINARY_DIR}/lldb-test-build.noindex" CACHE PATH "The build root for building tests.")
 
 # Configure and create module cache directories.


        


More information about the lldb-commits mailing list