[Lldb-commits] [PATCH] D107341: [lldb] Move comment about noindex next to line it refers to

[Nico Weber via Phabricator via lldb-commits]

thakis created this revision.
thakis added a reviewer: JDevlieghere.
thakis added a project: LLDB.
Herald added subscribers: arphaman, mgorny.
thakis requested review of this revision.

The comment was originally added in 34769d80d. Then D44526 <https://reviews.llvm.org/D44526>
removed the flag added there (but kept the comment), and then
D66966 <https://reviews.llvm.org/D66966> reintroduced a .noindex dir (which D68606 <https://reviews.llvm.org/D68606> and then 33fca97880
moved around a bit).

No behavior change.


https://reviews.llvm.org/D107341

Files:
  lldb/test/API/CMakeLists.txt
  lldb/test/CMakeLists.txt


Index: lldb/test/CMakeLists.txt
===================================================================
--- lldb/test/CMakeLists.txt
+++ lldb/test/CMakeLists.txt
@@ -12,6 +12,11 @@
 endif()
 
 # Configure the build directory.
+# The .noindex suffix is a marker for Spotlight to never index the
+# build directory.  LLDB queries Spotlight to locate .dSYM bundles
+# based on the UUID embedded in a binary, and because the UUID is a
+# hash of filename and .text section, there *will* be conflicts inside
+# the build directory.
 set(LLDB_TEST_BUILD_DIRECTORY "${PROJECT_BINARY_DIR}/lldb-test-build.noindex" CACHE PATH "The build root for building tests.")
 
 # Configure and create module cache directories.
Index: lldb/test/API/CMakeLists.txt
===================================================================
--- lldb/test/API/CMakeLists.txt
+++ lldb/test/API/CMakeLists.txt
@@ -37,11 +37,6 @@
   ""
   CACHE STRING "Specify additional arguments to pass to test runner. For example: '-C gcc -C clang -A i386 -A x86_64'")
 
-# The .noindex suffix is a marker for Spotlight to never index the
-# build directory.  LLDB queries Spotlight to locate .dSYM bundles
-# based on the UUID embedded in a binary, and because the UUID is a
-# hash of filename and .text section, there *will* be conflicts inside
-# the build directory.
 set(LLDB_TEST_COMMON_ARGS
   -u CXXFLAGS
   -u CFLAGS


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D107341.363690.patch
Type: text/x-patch
Size: 1377 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20210803/075747f3/attachment.bin>