[Lldb-commits] [PATCH] D107295: [lldb] Use a struct to pass function search options to Module::FindFunction

[Shafik Yaghmour via Phabricator via lldb-commits]

shafik added inline comments.


================
Comment at: lldb/source/API/SBModule.cpp:401-403
+    ModuleFunctionOptions function_options;
+    function_options.include_symbols = true;
+    function_options.include_inlines = true;
----------------
bulbazord wrote:
> nit: IMO this looks cleaner, but no big deal:
> ```
> ModuleFunctionOptions function_options = { .include_symbols = true, .include_inlines = true };
> ```
I love designated initializers (this is a nice use) but this is a C++20 feature and so we would be using this as a GNU extension, which might break some builds.

godbolt: https://godbolt.org/z/TKMddMrq3


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107295/new/

https://reviews.llvm.org/D107295