[Lldb-commits] [PATCH] D107206: [lldb] Refactor IRExecutionUnit::FindInSymbols (NFC)

[Shafik Yaghmour via Phabricator via lldb-commits]

shafik added a comment.

Thank you for refactoring this, besides my comment on the lambda the rest makes sense.



================
Comment at: lldb/source/Expression/IRExecutionUnit.cpp:785
+  auto get_external_load_address =
+      [target, &symbol_was_missing_weak](
+          lldb::addr_t &load_address, lldb::addr_t &best_internal_load_address,
----------------
It feels like the lambda should really be a small `class` that tracks the state of `load_address` and `best_internal_load_address` over multiple calls and then the user can access the state. 

The lambda is doing a lot of logic and there is state being carried across calls and that feels like we have crossed the boundary and a class would be better.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107206/new/

https://reviews.llvm.org/D107206