[Lldb-commits] [PATCH] D107206: [lldb] Refactor IRExecutionUnit::FindInSymbols (NFC)

Jonas Devlieghere via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Jul 30 18:45:17 PDT 2021


JDevlieghere created this revision.
JDevlieghere added reviewers: jingham, teemperor.
JDevlieghere requested review of this revision.

As I was trying to understand what `IRExecutionUnit::FindInSymbols` was doing, I couldn't help myself but refactor the code a little bit:

- No else after return.
- Move the lambda out of the loop.
- Replace `GetSize() == 0` with `IsEmpty()`
- Eliminate pitfall of not clearing the `SymbolContextList` by moving it into the lexical scope of the if-clause.

And probably some other small things that bothered me.


https://reviews.llvm.org/D107206

Files:
  lldb/source/Expression/IRExecutionUnit.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D107206.363246.patch
Type: text/x-patch
Size: 8371 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20210731/d472d782/attachment.bin>


More information about the lldb-commits mailing list