[Lldb-commits] [PATCH] D100299: Be lazier about loading .dwo files

Fri Jul 30 15:37:28 PDT 2021

stella.stamenova added a comment.

In D100299#2917598 <https://reviews.llvm.org/D100299#2917598>, @jankratochvil wrote:

> In D100299#2917467 <https://reviews.llvm.org/D100299#2917467>, @Eric wrote:
>
>> Is arm hardware necessary to test this,
>
> In this case it is not as it does not require linking. Usually I find easier to run it natively than to setup all the cross-compilation libraries and include files. I agree it was my mistake as the cross-compilation is easier in this case.
>
>> or can the test be modified to cross-compile to arm to see what is going on?
>
> In fact it is visible already from the build log <https://lab.llvm.org/buildbot/api/v2/logs/7402790/raw> and it is then obvious from source code <https://github.com/llvm/llvm-project/blob/8dfd6cae9bd62ae5ef056b994ece2e98f1558830/lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp#L2592>. I did not see it first from the default shortened dump.
>
>> Is there a way to determine what build target the test bot is using?
>
> Yes, `armv8l-unknown-linux-gnueabihf`.
>
>> In any case the broken test doesn't exercise lldb at all so it could be separated from the patch.
>
> If the test did not exercise LLDB it should have been removed. But it does exercise LLDB.
>
> I have added to `lldb/test/Shell/SymbolFile/DWARF/split-optimized.c`:
>
>   +// ObjectFileELF::ApplyRelocations does not implement arm32.
>   +// XFAIL: target-arm && linux-gnu
>
> Hopefully it will satisfy the buildbot now.

This also fails on the Windows lldb bot:

https://lab.llvm.org/buildbot/#/builders/83/builds/8842

Perhaps something more than several xfails is needed?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100299/new/

https://reviews.llvm.org/D100299