[Lldb-commits] [lldb] fe23f0c - [lldb] Always codesign binaries on macOS

Jonas Devlieghere via lldb-commits lldb-commits at lists.llvm.org
Fri Jul 30 11:19:47 PDT 2021


Author: Jonas Devlieghere
Date: 2021-07-30T11:19:40-07:00
New Revision: fe23f0c73ab774e8765d221bdef3060c59294a02

URL: https://github.com/llvm/llvm-project/commit/fe23f0c73ab774e8765d221bdef3060c59294a02
DIFF: https://github.com/llvm/llvm-project/commit/fe23f0c73ab774e8765d221bdef3060c59294a02.diff

LOG: [lldb] Always codesign binaries on macOS

Always codesign binaries on macOS. Apple Silicon has stricter
codesigning requirements, for example requiring macCatalyst binaries to
be signed. Ad-hoc sign everything like we do for other Darwin platforms.

Added: 
    

Modified: 
    lldb/packages/Python/lldbsuite/test/builders/darwin.py

Removed: 
    


################################################################################
diff  --git a/lldb/packages/Python/lldbsuite/test/builders/darwin.py b/lldb/packages/Python/lldbsuite/test/builders/darwin.py
index c4a057e7158af..4cd31a6a8033f 100644
--- a/lldb/packages/Python/lldbsuite/test/builders/darwin.py
+++ b/lldb/packages/Python/lldbsuite/test/builders/darwin.py
@@ -76,6 +76,8 @@ def getExtraMakeArgs(self):
             entitlements = os.path.join(test_dir, 'make', entitlements_file)
             args['CODESIGN'] = 'codesign --entitlements {}'.format(
                 entitlements)
+        else:
+            args['CODESIGN'] = 'codesign'
 
         # Return extra args as a formatted string.
         return ' '.join(


        


More information about the lldb-commits mailing list