[Lldb-commits] [PATCH] D107182: [LLDB][GUI] Refactor form drawing using subsurfaces

Omar Emara via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Jul 30 10:23:06 PDT 2021


OmarEmaraDev created this revision.
OmarEmaraDev added a reviewer: clayborg.
Herald added a reviewer: teemperor.
OmarEmaraDev requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.

This patch adds a new method SubSurface to the Surface class. The method
returns another surface that is a subset of this surface. This is
important to further abstract away drawing from the ncurses objects. For
instance, fields could previously be drawn on subpads only but can now
be drawn on any surface. This is needed to create the file search
dialogs and similar functionalities.

There is an opportunity to refactor window drawing in general using
surfaces, but we shall consider this separately later.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D107182

Files:
  lldb/source/Core/IOHandlerCursesGUI.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D107182.363137.patch
Type: text/x-patch
Size: 11843 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20210730/8209d9c1/attachment.bin>


More information about the lldb-commits mailing list