[Lldb-commits] [PATCH] D107140: [lldb] Show memory tags in memory read output

[David Spickett via Phabricator via lldb-commits]

DavidSpickett added reviewers: omjavaid, pcc.
DavidSpickett added a subscriber: pcc.
DavidSpickett added a comment.

DumpDataExtractor has formatting unittests. Due to memory tags being read from the execution context there are no new unittests. (the existing ones pass)

Also since this code isn't exactly simple and could have issues, and tags will be right most of the time I think an opt in to this feature makes sense. I haven't added that here yet but will do if you agree. Not yet sure if it would be an option to "memory read", or a debugger setting.

@pcc We talked about tag formatting in an earlier patch. Your feedback on the format I've gone with would be great.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107140/new/

https://reviews.llvm.org/D107140