[Lldb-commits] [PATCH] D68671: Add the ability to pass extra args to a Python breakpoint command function

[walter erquinigo via Phabricator via lldb-commits]

wallace added inline comments.


================
Comment at: lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_command/TestBreakpointCommand.py:21
     @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr24528")
-    def test_breakpoint_command_sequence(self):
+    def not_test_breakpoint_command_sequence(self):
         """Test a sequence of breakpoint command add, list, and delete."""
----------------
jingham wrote:
> wallace wrote:
> > I've been trying to track a regression in source maps between Android Studio versions and it seems that this test shouldn't have been disabled. :(
> Yup, my bad.  I sometimes disable tests this way when I'm only trying to run one test in the set a bunch of times.  I must have forgotten to set it back.  Thanks for catching this!
No worries!! It was fun, though


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68671/new/

https://reviews.llvm.org/D68671