[Lldb-commits] [PATCH] D107079: [lldb] Change the log format to JSON instead of plain text

[David Spickett via Phabricator via lldb-commits]

DavidSpickett added a comment.

> With the added channels in each message we could just do the filtering on our side and tell people to just enable every channel in every category.

+1 to this, was the first thing I tried to do on the viewer you linked.

> Will there be an upstream log viewer? I don't know, but we could easily put a simple one on the website that just formats a log as a simple HTML table. That is easily done in vanilla JavaScript. But that should be a follow up patch.

As in on llvm.org? That would be neat.

Python does great with JSON so I'm sure it would be easy to hack on more specific scripts later too.

Will you be adding documentation about what the format is? (said web page would be a good place for it actually)

I know it won't be that complicated but it's always nice to see the total set of fields you might expect.



================
Comment at: lldb/packages/Python/lldbsuite/test/lldbutil.py:115
+    if not log_contents.endswith("]"):
+      log_contents = log_contents + "]"
+
----------------
What is the situation where you *would* have [, ] already? Will this be parsing raw text as well as output that is already JSON.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107079/new/

https://reviews.llvm.org/D107079