[Lldb-commits] [PATCH] D106584: [lldb] Assert file cache and live memory are equal on debug builds

Tue Jul 27 11:19:00 PDT 2021

JDevlieghere added a comment.

In D106584#2907898 <https://reviews.llvm.org/D106584#2907898>, @jasonmolenda wrote:

> Looks good!  Maybe we should add a setting like target.file-cache-memory-reads-verify (a boolean) to enable/disable this check instead of keying off NDEBUG.  We can turn it on in the testsuite, and we can optionally have people with release installs of lldb enable it if we ever suspect that it might be an issue.  The settings are added with an entry in source/Target/TargetProperties.td and a getter/setter in TargetProperties.

If we do that we should make it an `lldbassert` so it prints something in release builds.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106584/new/

https://reviews.llvm.org/D106584