[Lldb-commits] [PATCH] D106270: [DWARF5] Fix offset check when using .debug_names

[Kim-Anh Tran via Phabricator via lldb-commits]

kimanh added inline comments.


================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:3024
-        m_index->GetGlobalVariables(
-            dwarf_cu->GetNonSkeletonUnit(), [&](DWARFDIE die) {
-              VariableSP var_sp(
----------------
shafik wrote:
> So is the problem that calling `GetNonSkeletonUnit()` does not work here b/c in `DebugNamesDWARFIndex` case we don't want this but in the other cases we do? 
> 
> 
Yes, that's correct!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106270/new/

https://reviews.llvm.org/D106270