[Lldb-commits] [PATCH] D106712: Remember to check whether the current thread is stopped for a no-stop signal

[Shafik Yaghmour via Phabricator via lldb-commits]

shafik added inline comments.


================
Comment at: lldb/source/Target/Process.cpp:780
         StopReason curr_thread_stop_reason = eStopReasonInvalid;
-        if (curr_thread) {
+        bool prefer_curr_thread = false;
+        if (curr_thread && curr_thread->IsValid()) {
----------------
If we are setting `prefer_curr_thread` here, which I think is good, then I don't think we need to the `prefer_curr_thread = false;` lines in the switch. This will simplfiy the `if/else` below since we only care about the `true` case then.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106712/new/

https://reviews.llvm.org/D106712