[Lldb-commits] [lldb] e42edce - [lldb][NFC] Delete unused and commented out DWARF constants

[Alex Langford via lldb-commits]

Author: Alex Langford
Date: 2021-07-26T12:26:35-07:00
New Revision: e42edce4a349efeedde2ffd07a26a6335178d24b

URL: https://github.com/llvm/llvm-project/commit/e42edce4a349efeedde2ffd07a26a6335178d24b
DIFF: https://github.com/llvm/llvm-project/commit/e42edce4a349efeedde2ffd07a26a6335178d24b.diff

LOG: [lldb][NFC] Delete unused and commented out DWARF constants

I cannot find any users of these anywhere and they have been commented out
for years.

Added: 
    

Modified: 
    lldb/include/lldb/Core/dwarf.h
    lldb/packages/Python/lldbsuite/test/lldbdwarf.py

Removed: 
    


################################################################################
diff  --git a/lldb/include/lldb/Core/dwarf.h b/lldb/include/lldb/Core/dwarf.h
index bdb6f27a45214..968418e71c2f3 100644
--- a/lldb/include/lldb/Core/dwarf.h
+++ b/lldb/include/lldb/Core/dwarf.h
@@ -38,39 +38,6 @@ typedef uint32_t dw_offset_t; // Dwarf Debug Information Entry offset for any
 
 #define DW_EH_PE_MASK_ENCODING 0x0F
 
-//// The following are used only internally within lldb - don't
-//// document them in the llvm Dwarf.h header file, we won't see
-//// them in executable files anywhere.
-//// These constants fit between DW_OP_lo_user (0xe0) and DW_OP_hi_user (0xff).
-//
-//#define DW_OP_APPLE_array_ref     0xEE // first pops index, then pops array;
-//pushes array[index]
-//#define DW_OP_APPLE_extern        0xEF // ULEB128 index of external object
-//(i.e., an entity from the program that was used in the expression)
-#define DW_OP_APPLE_uninit                                                     \
-  0xF0 // This is actually generated by some apple compilers in locations lists
-//#define DW_OP_APPLE_assign        0xF1 // pops value off and assigns it to
-//second item on stack (2nd item must have assignable context)
-//#define DW_OP_APPLE_address_of    0xF2 // gets the address of the top stack
-//item (top item must be a variable, or have value_type that is an address
-//already)
-//#define DW_OP_APPLE_value_of      0xF3 // pops the value off the stack and
-//pushes the value of that object (top item must be a variable, or expression
-//local)
-//#define DW_OP_APPLE_deref_type    0xF4 // gets the address of the top stack
-//item (top item must be a variable, or a clang type)
-//#define DW_OP_APPLE_expr_local    0xF5 // ULEB128 expression local index
-//#define DW_OP_APPLE_constf        0xF6 // 1 byte float size, followed by
-//constant float data
-//#define DW_OP_APPLE_scalar_cast   0xF7 // Cast top of stack to 2nd in stack's
-//type leaving all items in place
-//#define DW_OP_APPLE_clang_cast    0xF8 // pointer size clang::Type * off the
-//stack and cast top stack item to this type
-//#define DW_OP_APPLE_clear         0xFE // clears the entire expression stack,
-//ok if the stack is empty
-//#define DW_OP_APPLE_error         0xFF // Stops expression evaluation and
-//returns an error (no args)
-
 typedef lldb_private::RangeVector<dw_addr_t, dw_addr_t, 2> DWARFRangeList;
 
 #endif // LLDB_CORE_DWARF_H

diff  --git a/lldb/packages/Python/lldbsuite/test/lldbdwarf.py b/lldb/packages/Python/lldbsuite/test/lldbdwarf.py
index 217f8bc0e2b77..5492960d2d75e 100644
--- a/lldb/packages/Python/lldbsuite/test/lldbdwarf.py
+++ b/lldb/packages/Python/lldbsuite/test/lldbdwarf.py
@@ -159,7 +159,6 @@
 DW_OP_stack_value                   = 0x9F
 DW_OP_lo_user                       = 0xE0
 DW_OP_GNU_push_tls_address          = 0xE0
-DW_OP_APPLE_uninit                  = 0xF0
 DW_OP_hi_user                       = 0xFF