[Lldb-commits] [PATCH] D106553: [LLDB][GUI] Resolve paths in file/directory fields

Greg Clayton via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Jul 26 10:45:30 PDT 2021


clayborg accepted this revision.
clayborg added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lldb/source/Core/IOHandlerCursesGUI.cpp:1308
     }
     if (FileSystem::Instance().IsDirectory(file)) {
       SetError("Not a file!");
----------------
OmarEmaraDev wrote:
> clayborg wrote:
> > This is checking for a directory, not a file
> Not sure what you mean. It is setting an error if the file was in fact a directory,
Woops! You are right...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106553/new/

https://reviews.llvm.org/D106553



More information about the lldb-commits mailing list