[Lldb-commits] [PATCH] D105180: [lldb][AArch64] Add memory tag writing to lldb-server

[Muhammad Omair Javaid via Phabricator via lldb-commits]

omjavaid added inline comments.


================
Comment at: lldb/test/API/tools/lldb-server/memory-tagging/TestGdbRemoteMemoryTagging.py:56
         # Run the packet stream
         context = self.expect_gdbremote_sequence()
         self.assertIsNotNone(context)
----------------
DavidSpickett wrote:
> omjavaid wrote:
> > omjavaid wrote:
> > > DavidSpickett wrote:
> > > > omjavaid wrote:
> > > > > This test is still not stable given we wait for stop notification while process may have exited. This causes test to hang till timeout expiry.
> > > > Sure, but I don't think there's a better way to do it. Short of reading from a process that's already exited. (which seems to sort of work for memory but tags have weird results so I don't think it's meant to work)
> > > > 
> > > > Note that the test file does pause after the print: https://github.com/llvm/llvm-project/blob/main/lldb/test/API/tools/lldb-server/memory-tagging/main.c#L16
> > > > 
> > > > We've got a few scenarios:
> > > > * All goes well, we get the print. The test program is in it's delay and we stop it.
> > > > * The test crashes at some point before sending the stop. The test program waits 60s then exits.
> > > > * The test program crashes before printing. The test waits on the print until it times out.
> > > > * The test picks up the print just as the test program is exiting, or has already exited. The test times out waiting for the stop response.
> > > > 
> > > > It's not free of timing issues but it means that you won't have either test or test program hanging around if either fails.
> > > > 
> > > > What do you think?
> > > The problem I was facing was lldb-server existed after inferior launch. I have given my configuration below I might be doing something wrong:
> > > LLDB_TEST_COMPILER=/home/omair/work/tools/gcc-linaro-11.0.0-2021.02-x86_64_aarch64-linux-gnu/bin/aarch64-linux-gnu-gcc
> > > LLDB_TEST_ARCH=aarch64
> > > 
> > > LLDB_PLATFORM_NAME=remote-linux
> > > LLDB_PLATFORM_URL=connect://192.168.53.253:54321
> > > #-u CXXFLAGS -u CFLAGS --env ARCHIVER=/usr/bin/ar --env OBJCOPY=/usr/bin/objcopy \
> > > 
> > > $LLDB_BUILD_DIR/bin/lldb-dotest \
> > > -A $LLDB_TEST_ARCH \
> > > -C $LLDB_TEST_COMPILER \
> > > --build-dir $LLDB_BUILD_DIR/lldb-test-build.noindex \
> > > --executable $LLDB_BUILD_DIR/bin/lldb \
> > > --dsymutil $LLDB_BUILD_DIR/bin/dsymutil \
> > > --llvm-tools-dir $LLDB_BUILD_DIR/bin \
> > > --lldb-libs-dir $LLDB_BUILD_DIR/lib \
> > > --platform-name=$LLDB_PLATFORM_NAME \
> > > --platform-url=$LLDB_PLATFORM_URL \
> > > -p $1 $2 $3
> > > 
> > @DavidSpickett  any update on above issue?
> If I plug my paths into that script it runs fine for me.
> 
> Can you write out what you think is going on? I don't understand what you're seeing and without a way to reproduce myself I'm just guessing. (which are the scenarios I outlined above)
> 
> When you run it what's the lifetime of the test, the lldb-server on the remote, the test program it's running. That sort of thing.
> 
> 
I think my qemu rootfs is misconfigured may be not sure thought

Log with Dynamically linked executable:
sending packet to remote: $A332,0,2f686f6d652f6f6d6169722f776f726b2f6c6c64622f6c6c64622d6465762f6275696c642f72656c656173652f686f73742f6c6c64622d746573742d6275696c642e6e6f696e6465782f746f6f6c732f6c6c64622d7365727665722f6d656d6f72792d74616767696e672f5465737447646252656d6f74654d656d6f727954616767696e672e746573745f514d656d546167735f7061636b6574735f6c6c67732f612e6f7574#5f
Launched '/home/omair/work/lldb/lldb-dev/build/release/host/lldb-test-build.noindex/tools/lldb-server/memory-tagging/TestGdbRemoteMemoryTagging.test_QMemTags_packets_llgs/a.out' as process 32041...
R packet to remote: $OK#9a
sending packet to remote: $qLaunchSuccess#a5
R packet to remote: $OK#9a
sending packet to remote: $c#63
R packet to remote: /lib/ld-linux-aarch64.so.1: No such file or directory


Log with static linked executable:

sending packet to remote: $A332,0,2f686f6d652f6f6d6169722f776f726b2f6c6c64622f6c6c64622d6465762f6275696c642f72656c656173652f686f73742f6c6c64622d746573742d6275696c642e6e6f696e6465782f746f6f6c732f6c6c64622d7365727665722f6d656d6f72792d74616767696e672f5465737447646252656d6f74654d656d6f727954616767696e672e746573745f714d656d546167735f7061636b6574735f6c6c67732f612e6f7574#61
Launched '/home/omair/work/lldb/lldb-dev/build/release/host/lldb-test-build.noindex/tools/lldb-server/memory-tagging/TestGdbRemoteMemoryTagging.test_qMemTags_packets_llgs/a.out' as process 439...
R packet to remote: $OK#9a
sending packet to remote: $qLaunchSuccess#a5
R packet to remote: $OK#9a
sending packet to remote: $c#63
R packet to remote: buffer: (nil) page_size: 0x1000



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105180/new/

https://reviews.llvm.org/D105180