[Lldb-commits] [PATCH] D105182: [lldb] Add "memory tag write" command

[Muhammad Omair Javaid via Phabricator via lldb-commits]

omjavaid accepted this revision.
omjavaid added a comment.
This revision is now accepted and ready to land.

LGTM after addressing comment above.



================
Comment at: lldb/test/API/linux/aarch64/mte_tag_access/main.c:10
 
+char *checked_mmap(size_t page_size, int prot) {
+  char *ptr = mmap(0, page_size, prot, MAP_PRIVATE | MAP_ANONYMOUS, -1, 0);
----------------
I think we should add a link to relevant information used to write this file. It makes use of arm_acle and MTE specific defs which should be explained or at least a link to relevant information should be given at the top for someone looking for explanation.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105182/new/

https://reviews.llvm.org/D105182