[Lldb-commits] [PATCH] D106270: [DWARF5] Fix offset check when using .debug_names

Jonas Devlieghere via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Jul 19 09:24:19 PDT 2021


JDevlieghere added inline comments.


================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/AppleDWARFIndex.cpp:82
 
+  const DWARFUnit &non_skeleton_cu = cu.GetNonSkeletonUnit();
   DWARFMappedHash::DIEInfoArray hash_data;
----------------
I assume the `const` of the `DWARFUnit` is being dropped because `GetNonSkeletonUnit`? Rather than doing that, can't that function be const instead? 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106270/new/

https://reviews.llvm.org/D106270



More information about the lldb-commits mailing list