[Lldb-commits] [PATCH] D106270: [DWARF5] Fix offset check when using .debug_names

Kim-Anh Tran via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Jul 19 06:24:13 PDT 2021


kimanh created this revision.
Herald added a subscriber: arphaman.
kimanh added a subscriber: pfaffe.
kimanh edited the summary of this revision.
kimanh added a reviewer: labath.
kimanh published this revision for review.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.

When going through the CU entries in the name index,
make sure to compare against the name entry's CU
offset against the skeleton CU's offset.

Previously there would be a mismatch, since the
wrong offset was compared, and thus no suitable
entry was found.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D106270

Files:
  lldb/source/Plugins/SymbolFile/DWARF/AppleDWARFIndex.cpp
  lldb/source/Plugins/SymbolFile/DWARF/AppleDWARFIndex.h
  lldb/source/Plugins/SymbolFile/DWARF/DWARFIndex.h
  lldb/source/Plugins/SymbolFile/DWARF/DebugNamesDWARFIndex.cpp
  lldb/source/Plugins/SymbolFile/DWARF/DebugNamesDWARFIndex.h
  lldb/source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.cpp
  lldb/source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.h
  lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
  lldb/test/Shell/SymbolFile/DWARF/x86/find-variable-file.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D106270.359763.patch
Type: text/x-patch
Size: 7309 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20210719/c680626a/attachment.bin>


More information about the lldb-commits mailing list