[Lldb-commits] [PATCH] D104697: [lldb] Remove more redundant SetStatus(eReturnStatusFailed)

Raphael Isemann via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Jun 22 03:40:24 PDT 2021


teemperor accepted this revision.
teemperor added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lldb/source/Commands/CommandObjectReproducer.cpp:141
 static void SetError(CommandReturnObject &result, Error err) {
-  result.GetErrorStream().Printf("error: %s\n",
-                                 toString(std::move(err)).c_str());
-  result.SetStatus(eReturnStatusFailed);
+  result.AppendError(toString(std::move(err)).c_str());
 }
----------------
You can drop the `c_str()`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104697/new/

https://reviews.llvm.org/D104697



More information about the lldb-commits mailing list