[Lldb-commits] [PATCH] D104697: [lldb] Remove more redundant SetStatus(eReturnStatusFailed)

[David Spickett via Phabricator via lldb-commits]

DavidSpickett created this revision.
DavidSpickett requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.

Mostly by converting uses of GetErrorStream to AppendError,
so that the call to SetStatus is implicit.

Some remain where it isn't certain that you'll have a message
to set, or you want the output to be on stdout.

One place in CommandObjectWatchpoint previously didn't set
the status to failed at all. However it's pretty obvious
that it should do so.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D104697

Files:
  lldb/source/Commands/CommandObjectPlatform.cpp
  lldb/source/Commands/CommandObjectReproducer.cpp
  lldb/source/Commands/CommandObjectTarget.cpp
  lldb/source/Commands/CommandObjectVersion.cpp
  lldb/source/Commands/CommandObjectWatchpoint.cpp
  lldb/source/Interpreter/CommandObject.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D104697.353593.patch
Type: text/x-patch
Size: 8386 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20210622/ae67c362/attachment-0001.bin>