[Lldb-commits] [PATCH] D104380: [lldb] Set return object failed status even if error string is empty

[David Spickett via Phabricator via lldb-commits]

DavidSpickett added a comment.

This change would have been part of https://reviews.llvm.org/D103701 if I had realised that this was in fact how it worked. I separated it from the follow ons because of that and to not bury 3 lines of change that apply to all callers of these functions, in 300 lines of change to callers of `SetStatus(eReturnStatusFailed)`. If I were bisecting a failure caused by these changes I'd appreciate the separation but there's probably not much difference.

I agree about the assert, if you're not meant to pass empty strings we should enforce that. I'll get something into review.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104380/new/

https://reviews.llvm.org/D104380