[Lldb-commits] [PATCH] D104488: Create synthetic symbol names on demand to improve memory consumption and startup times.

[walter erquinigo via Phabricator via lldb-commits]

wallace added a comment.

lgtm

I wonder if it's lldb's style to rename m_mangled to m_mangled_do_not_use (or something like that) to prevent people from using it in the future.



================
Comment at: lldb/source/Symbol/Symtab.cpp:625
+  // with a prefix and end with a the symbol UserID, so allow users to find
+  // these without having to add them to the name indexes. This queries will
+  // not happen very often since the names don't mean anything, so performance
----------------
these queries


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104488/new/

https://reviews.llvm.org/D104488