[Lldb-commits] [PATCH] D103500: [trace][intel-pt] Create basic SB API

[Greg Clayton via Phabricator via lldb-commits]

clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.

a few nits!



================
Comment at: lldb/include/lldb/API/SBTarget.h:847
+  /// \return
+  ///   The trace object. It might be undefined.
+  lldb::SBTrace GetTrace();
----------------
rephrase the "It might be undefined.". Maybe "The returned SBTrace object might not be valid, check with a call to "bool SBTrace::IsValid();" to check."


================
Comment at: lldb/include/lldb/Target/Trace.h:256
+  virtual llvm::Error Start(
+      const std::vector<lldb::tid_t> &tids,
+      StructuredData::ObjectSP configuration = StructuredData::ObjectSP()) = 0;
----------------
ArrayRef?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103500/new/

https://reviews.llvm.org/D103500