[Lldb-commits] [lldb] 0f94d68 - [lldb] Add missing changes to a2363c0cf9b6a9a81c76ac652da667f73845d38b

David Spickett via lldb-commits lldb-commits at lists.llvm.org
Mon Jun 14 02:24:03 PDT 2021


Author: David Spickett
Date: 2021-06-14T09:23:30Z
New Revision: 0f94d68a2e15d50796439f20bcb508b95931d2ae

URL: https://github.com/llvm/llvm-project/commit/0f94d68a2e15d50796439f20bcb508b95931d2ae
DIFF: https://github.com/llvm/llvm-project/commit/0f94d68a2e15d50796439f20bcb508b95931d2ae.diff

LOG: [lldb] Add missing changes to a2363c0cf9b6a9a81c76ac652da667f73845d38b

Completely forgot to actually update the change before relanding it.
This adds the Darwin AVX changes.

Added: 
    

Modified: 
    lldb/test/API/commands/register/register/register_command/TestRegisters.py

Removed: 
    


################################################################################
diff  --git a/lldb/test/API/commands/register/register/register_command/TestRegisters.py b/lldb/test/API/commands/register/register/register_command/TestRegisters.py
index 7acf3a409875..96e6c8065e82 100644
--- a/lldb/test/API/commands/register/register/register_command/TestRegisters.py
+++ b/lldb/test/API/commands/register/register/register_command/TestRegisters.py
@@ -402,8 +402,13 @@ def fp_register_write(self):
             # Returns an SBValueList.
             registerSets = currentFrame.GetRegisters()
             for registerSet in registerSets:
-                if 'advanced vector extensions' in registerSet.GetName().lower():
+                set_name = registerSet.GetName().lower()
+                if 'advanced vector extensions' in set_name:
                     has_avx = True
+                # Darwin reports AVX registers as part of "Floating Point Registers"
+                else if self.platformIsDarwin() and 'floating point registers' in set_name:
+                    has_avx = registerSet.GetFirstValueByName('ymm0').IsValid()
+
                 # FreeBSD/NetBSD reports missing register sets 
diff erently
                 # at the moment and triggers false positive here.
                 # TODO: remove FreeBSD/NetBSD exception when we make unsupported


        


More information about the lldb-commits mailing list