[Lldb-commits] [PATCH] D104091: [NFC] Fix leak in test
Vitaly Buka via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Thu Jun 10 18:43:57 PDT 2021
vitalybuka created this revision.
vitalybuka requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
Test leaks if we run
tools/lldb/unittests/Host/HostTests without --gtest_filter
Also if we call HostInfoLinux::Initialize twice
some llvm::call_once will prevent initialization of some fields.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D104091
Files:
lldb/source/Host/linux/HostInfoLinux.cpp
lldb/unittests/Host/HostInfoTest.cpp
Index: lldb/unittests/Host/HostInfoTest.cpp
===================================================================
--- lldb/unittests/Host/HostInfoTest.cpp
+++ lldb/unittests/Host/HostInfoTest.cpp
@@ -60,3 +60,16 @@
EXPECT_TRUE(HostInfo::GetXcodeSDKPath(XcodeSDK("CeciNestPasUnOS.sdk")).empty());
}
#endif
+
+TEST(HostInfoTest2, InitTwice) {
+ llvm::VersionTuple Version;
+ {
+ SubsystemRAII<FileSystem, HostInfo> subsystems;
+ Version = HostInfo::GetOSVersion();
+ }
+
+ {
+ SubsystemRAII<FileSystem, HostInfo> subsystems;
+ EXPECT_EQ(Version, HostInfo::GetOSVersion());
+ }
+}
Index: lldb/source/Host/linux/HostInfoLinux.cpp
===================================================================
--- lldb/source/Host/linux/HostInfoLinux.cpp
+++ lldb/source/Host/linux/HostInfoLinux.cpp
@@ -35,8 +35,8 @@
void HostInfoLinux::Initialize(SharedLibraryDirectoryHelper *helper) {
HostInfoPosix::Initialize(helper);
-
- g_fields = new HostInfoLinuxFields();
+ if (!g_fields)
+ g_fields = new HostInfoLinuxFields();
}
llvm::VersionTuple HostInfoLinux::GetOSVersion() {
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D104091.351330.patch
Type: text/x-patch
Size: 1095 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20210611/41bfb5c1/attachment.bin>
More information about the lldb-commits
mailing list