[Lldb-commits] [PATCH] D103575: Allow signposts to take advantage of deferred string substitution

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere added a comment.

In D103575#2804151 <https://reviews.llvm.org/D103575#2804151>, @aprantl wrote:

> I'm not sure I fully understand the suggestion:
>
>> I think we should just remove the functionality form the timer class again. I only added it there because of the macro.
>
> ... and replace its uses with what?

I'm suggesting we no longer emit a signpost from the `lldb_private::Timer` class and instead exclusively emit a signpost from the `LLDB_SCOPED_TIMER` macro. We barely have any places where someone creates a timer directly and this would help discourage that further. The only reason it's currently in the timer class it because it seemed cleaner than doing it in the macro directly. Since we now have to emit the signpost from the `LLDB_SCOPED_TIMER` macro anyway, there's no reason to keep the functionality in the Timer class.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103575/new/

https://reviews.llvm.org/D103575