[Lldb-commits] [PATCH] D103271: [lldb/Target] Select most relevant frame only in case of signal

[Jim Ingham via Phabricator via lldb-commits]

jingham added a comment.

I don't think it's right to do it in GetStackFrameAtIndex.  For instance, suppose lldb stops somewhere, and the user does a backtrace, then they select a different frame on the stack, and then invoke some other command that happens to ask for the frame at index 0.  If that subsequent GetStackFrameAtIndex(0) request triggers the recognizer to select a different frame, that would be surprising and not desirable.

I think you need to do this somewhere in the StackFrameList, somewhere where we start filling in frames (maybe GetFramesUpTo) but you are going to have to be careful here to avoid recursion as well.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103271/new/

https://reviews.llvm.org/D103271