[Lldb-commits] [PATCH] D103701: [lldb] Set return status to failed when adding a command error

[Raphael Isemann via Phabricator via lldb-commits]

teemperor added a comment.

In D103701#2804840 <https://reviews.llvm.org/D103701#2804840>, @DavidSpickett wrote:

> I've gone ahead and landed it, will revert on failures.
>
> Got patches to remove the reundant calls locally so I'll put those up for review once this has had time to go through.
> (those changes will be fairly mechanical but it's worth someone scanning them for silly mistakes)

SGTM. My macOS node is suffering from some unrelated failures so I couldn't let this run over all tests yet, but if the next GreenDragon iteration is green then this should be fine.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103701/new/

https://reviews.llvm.org/D103701