[Lldb-commits] [PATCH] D103588: [trace] Create a top-level instruction class

Mon Jun 7 22:56:33 PDT 2021

clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.

One quick either documentation update for the error string, or switch to ConstString... Probably best to the the error string docs as if we use fancy C++ union stuff it might not compile for everyone on all C++ compilers..

================
Comment at: lldb/include/lldb/Target/Trace.h:75
+    lldb::addr_t m_load_address;
+    const char *m_error;
+  } m_data;
----------------
I would be great if this could actually be a ConstString object. I haven't played with C++ unions with actual objects in them, but I believe it is possible. If you can't make a comment stating this string will be from a ConstString and doesn't need to be freed.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103588/new/

https://reviews.llvm.org/D103588