[Lldb-commits] [PATCH] D101128: [lldb-vscode] only report long running progress events

[walter erquinigo via Phabricator via lldb-commits]

wallace updated this revision to Diff 350419.
wallace added a comment.

Addressed the comments except for the "static function that we can call and remove the passing of the instance variable for the report callback all over to the event classes". That's a little bit hard to achieve because the callback requires an instance of VSCode, so it can't easily be fully static. I think it's fine to the callbacks as they are not used in too many places.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101128/new/

https://reviews.llvm.org/D101128

Files:
  lldb/tools/lldb-vscode/ProgressEvent.cpp
  lldb/tools/lldb-vscode/ProgressEvent.h
  lldb/tools/lldb-vscode/VSCode.cpp
  lldb/tools/lldb-vscode/VSCode.h
  lldb/tools/lldb-vscode/lldb-vscode.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D101128.350419.patch
Type: text/x-patch
Size: 18733 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20210607/94943ee8/attachment-0001.bin>