[Lldb-commits] [PATCH] D100806: [lldb] Fix one leak in reproducer

Jonas Devlieghere via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Apr 19 18:37:54 PDT 2021


JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.

This LGTM

In D100806#2700111 <https://reviews.llvm.org/D100806#2700111>, @MaskRay wrote:

> @JDevlieghere The Reproducer library seems to have several other leaks. Maybe you'd like to look at them? :) I am unfamiliar with the code...

Unfortunately I don't have bandwidth to look at that right now. IIRC there were a few places where we leaked on purpose during replay (we shouldn't be leaking anything during capture tho), but I'd have to take another look at the code to remember the details.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100806/new/

https://reviews.llvm.org/D100806



More information about the lldb-commits mailing list