[Lldb-commits] [PATCH] D100806: [lldb] Fix one leak in reproducer

[Jordan Rupprecht via Phabricator via lldb-commits]

rupprecht added inline comments.


================
Comment at: lldb/tools/driver/Driver.cpp:856
       if (const char *reproducer_path = SBReproducer::GetPath()) {
         // Leaking the string on purpose.
+        static std::string *finalize_cmd = new std::string(argv0);
----------------
This is no longer a leak (at least in the technical sense of "never freed, but also never inaccessible). Either remove this comment, or figure out if this is a load-bearing leak :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100806/new/

https://reviews.llvm.org/D100806