[Lldb-commits] [PATCH] D100243: [LLDB][GUI] Expand selected thread tree item by default

[Greg Clayton via Phabricator via lldb-commits]

clayborg added a comment.

Including the inlined comments for showing and selecting the selected frame.



================
Comment at: lldb/source/Core/IOHandlerCursesGUI.cpp:2211-2213
+          if (selected_thread->GetID() == thread->GetID()) {
+            item[i].Expand();
+          }
----------------
clayborg wrote:
> Remove parens for single statement if due to LLVM coding guidelines.
It would be great if we can also select the currently selected stack frame here. Something like:

```
if (selected_thread && selected_thread->GetID() == thread->GetID()) {
  item[i].Expand();
  StackFrameSP selected_frame = thread->GetSelectedFrame();
  if (selected_frame) {
    // Add all frames and select the right one...
  }
}
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100243/new/

https://reviews.llvm.org/D100243