[Lldb-commits] [PATCH] D100243: [LLDB][GUI] Expand selected thread tree item by default

Greg Clayton via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Apr 19 15:22:44 PDT 2021


clayborg added a comment.

I have been meaning to get to this for a while, thanks for taking this on! It would be great if we can actually select the selected stack frame as well when this the process view is initialized. Same kind of code as with the selected thread. See inline comments.



================
Comment at: lldb/source/Core/IOHandlerCursesGUI.cpp:1624-1626
+    if (m_parent == nullptr) {
+      m_is_expanded = true;
+    }
----------------
Remove parens for single statement if due to LLVM coding guidelines.


================
Comment at: lldb/source/Core/IOHandlerCursesGUI.cpp:2211-2213
+          if (selected_thread->GetID() == thread->GetID()) {
+            item[i].Expand();
+          }
----------------
Remove parens for single statement if due to LLVM coding guidelines.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100243/new/

https://reviews.llvm.org/D100243



More information about the lldb-commits mailing list