[Lldb-commits] [PATCH] D100338: Add a setting that enables memory to be read from the file cache instead of process when the section LLDB is reading from is read-only
Jason Molenda via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Tue Apr 13 11:13:35 PDT 2021
jasonmolenda added a comment.
I should say, my suggestion of changing Target::ReadMemory is just an opinion, please do feel free to disagree!
I think if you look at the callers, I suspect all (or nearly all) of them are passing prefer_file_cache == true right now, which is the force_live_memory==false default case. Anyone passing prefer_file_cache==false would want to pass force_live_memory==true, and it may be that they are doing this incorrect (you were originally looking at an instance where that was true in swift)
An example where we WANT prefer_file_cache==false aka force_live_memory==true is in CommandObjectMemory.cpp. When people use the memory read command, we want to show them the actual memory contents [*], we don't want to optimize by getting data from a file.
[X] we still replace breakpoint instructions with the real instruction when reading instructions, iirc.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the lldb-commits