[Lldb-commits] [PATCH] D100338: Add a setting that enables memory to be read from the file cache instead of process when the section LLDB is reading from is read-only

[Augusto Noronha via Phabricator via lldb-commits]

augusto2112 added a comment.

Thanks for the input @jasonmolenda. FWIW I also think it's worth implementing this correctly.

Could you help me figure out which callers I should change to `force_live_memory` though?

Here's a list of everywhere ReadMemory is called:

  SBTarget.cpp
      ReadInstructions
      ReadMemory
  
  CommandObjectMemory.cpp
      DoExecute
  
  Address.cpp
      ReadBytes
  
  Disassembler.cpp
      ParseInstructions
  
  Value.cpp
      GetValueAsData
  
  ValueObject.cpp
      GetPointeeData
  
  IRMemoryMap.cpp
      ReadMemory
  
  DynamicLoaderDarwinKernel.cpp
      ReadKextSummaries
      ReadKextSummaryHeader
  
  DynamicLoaderDarwin.cpp
      GetThreadLocalData
  
  EmulateInstructionMIPS.cpp
      SetInstruction
  
  UnwindAssemblyInstEmulation.cpp
      GetNonCallSiteUnwindPlanFromAssembly
  
  UnwindAssembly-x86.cpp
      AugmentUnwindPlanFromCallSite
      FirstNonPrologueInsn
      GetFastUnwindPlan
      GetNonCallSiteUnwindPlanFromAssembly
  
  Target.cpp  
      ReadCStringFromMemory
      ReadScalarIntegerFromMemory

Maybe force live memory only for the functions in `DynamicLoaderDarwinKernel.cpp` and `DynamicLoaderDarwin.cpp`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100338/new/

https://reviews.llvm.org/D100338