[Lldb-commits] [PATCH] D99867: [lldb] Replace unneeded use of Foundation with ObjectiveC in tests (NFC)

Dave Lee via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Sun Apr 4 16:09:32 PDT 2021

kastiglione added inline comments.

Comment at: lldb/test/API/commands/frame/recognizer/main.m:1
-#import <Foundation/Foundation.h>
+#import <objc/NSObject.h>
teemperor wrote:
> teemperor wrote:
> > I guess this could also be just `stdio.h` (FWIW, the printfs in tests can also be removed as they just require including system headers and are essentially never useful).
> Just to be clear: I'm just saying that removing `printfs` and everything else that references system headers is usually always a good idea but I'm not asking that you should remove them here too. The `stdio.h` is perfect for this patch.
thanks for reviewing closely, a bunch of these changes were automated  and I am guilty of not looking closely (if the test passed then I didn't look closer)

  rG LLVM Github Monorepo



More information about the lldb-commits mailing list