[Lldb-commits] [PATCH] D99702: [lldb-vscode] Use LLVM's ScopeExit to ensure we always terminate the debugger

David Blaikie via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Apr 1 12:26:52 PDT 2021

dblaikie added a comment.

@wallace - minor inconvenience, but approving a patch in Phabricator without any textual comment does not result in an email to the list, making it look like a patch is being committed without approval - could you include some text in your Phab approvals, as it makes it a bit easier when doing post-commit/process review?

@JDevlieghere Is it worth having a C++ RAII object that calls initialize in the ctor and terminate in the dtor? (maybe even removing the init/terminate free functions, and making them only accessible through an RAII object if that's suitable) What do the other uses of init/terminate look like/could they benefit from such refactoring?

  rG LLVM Github Monorepo



More information about the lldb-commits mailing list