[Lldb-commits] [PATCH] D99426: [Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text
Reid Kleckner via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Mon Mar 29 09:52:21 PDT 2021
rnk added a comment.
In D99426#2653725 <https://reviews.llvm.org/D99426#2653725>, @MaskRay wrote:
> This touches a lot of files. I am a bit worried that it would not be easy for a contributor to know OF_TextWithCRLF is needed to make SystemZ happy.
Right, we need to separate text-ness for System/Z EBCDIC re-encoding from Windows CRLF translation. I think it's best to have a separate, positive CRLF bit, and to make that spelling longer than OF_Text. I think, in general, more problems are caused by extra unintended CRLF than by missing carriage returns.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the lldb-commits